diff options
| author | robert <robertrussell.72001@gmail.com> | 2022-01-08 11:40:34 -0800 |
|---|---|---|
| committer | Hiltjo Posthuma <hiltjo@codemadness.org> | 2022-01-10 17:04:01 +0100 |
| commit | ea7cd7b62fdfa6a1fbd882d1565d557577f2cf32 (patch) | |
| tree | 5eafff9b5a615369874408a9820471982ac727b3 /%2525253fid%2525253d670ddec83f39b5544555952a7c737c878569e1a2%25253fid%25253d670ddec83f39b5544555952a7c737c878569e1a2%253fid%253d670ddec83f39b5544555952a7c737c878569e1a2%3fid%3db1d97fec47b0d6633addb848131388ec40154ebc?id=ea7cd7b62fdfa6a1fbd882d1565d557577f2cf32 | |
| parent | 7fb0c0cc681f36be2ad12091ef93a41671f32738 (diff) | |
Fix mousereport
This patch replaces the previous one I sent.
The following changes are made in this patch:
- Fix tracking of pressed buttons. Previously, pressing two buttons and
then releasing one would make st think no buttons are pressed, which
in particular broke MODE_MOUSEMOTION.
- Always send the lowest-numbered pressed button on motion events; when
no button is pressed for a motion event in MODE_MOUSEMANY, then send
a release. This matches the behaviour of xterm. (Previously, st sent
the most recently pressed button in the motion report.)
- Remove UB (?) access to potentially inactive struct member
e->xbutton.button of XEvent union.
- Fix (unlikely) possibility of overflow for large button numbers.
The one discrepancy I found between st and xterm is that xterm sometimes
encodes buttons with large numbers (>5) strangely. E.g., xterm reports
presses of buttons 8 and 9 as releases, whereas st properly (?) encodes
them as presses.
Diffstat (limited to '%2525253fid%2525253d670ddec83f39b5544555952a7c737c878569e1a2%25253fid%25253d670ddec83f39b5544555952a7c737c878569e1a2%253fid%253d670ddec83f39b5544555952a7c737c878569e1a2%3fid%3db1d97fec47b0d6633addb848131388ec40154ebc?id=ea7cd7b62fdfa6a1fbd882d1565d557577f2cf32')
0 files changed, 0 insertions, 0 deletions