diff options
Fix mousereport
This patch replaces the previous one I sent.
The following changes are made in this patch:
- Fix tracking of pressed buttons. Previously, pressing two buttons and
then releasing one would make st think no buttons are pressed, which
in particular broke MODE_MOUSEMOTION.
- Always send the lowest-numbered pressed button on motion events; when
no button is pressed for a motion event in MODE_MOUSEMANY, then send
a release. This matches the behaviour of xterm. (Previously, st sent
the most recently pressed button in the motion report.)
- Remove UB (?) access to potentially inactive struct member
e->xbutton.button of XEvent union.
- Fix (unlikely) possibility of overflow for large button numbers.
The one discrepancy I found between st and xterm is that xterm sometimes
encodes buttons with large numbers (>5) strangely. E.g., xterm reports
presses of buttons 8 and 9 as releases, whereas st properly (?) encodes
them as presses.
Diffstat (limited to '%2525252525252525253fid%2525252525252525253d8629d9a1da72cc18568a8f146307b0e939b77ebf%25252525252525253fid%25252525252525253def0551932fb162f907b40185d2f48c3b497708ee%252525252525253fid%252525252525253daf3bb68add1c40d19d0dee382009e21b0870a38f%2525252525253fid%2525252525253daf3bb68add1c40d19d0dee382009e21b0870a38f&id2%2525252525253d2aefa348baf4b702fdce98eb105bcba175d8283f%25252525253fid%25252525253daf3bb68add1c40d19d0dee382009e21b0870a38f%252525253fid%252525253d2aefa348baf4b702fdce98eb105bcba175d8283f%2525253fid%2525253de823e2308f2a99023032a3966ebb7036a31d305f%25253fid%25253d2c5edf28ec851907305d73c6218ce75d39f1767f%253fid%253d2c5edf28ec851907305d73c6218ce75d39f1767f%3fid%3db1d97fec47b0d6633addb848131388ec40154ebc?id=ea7cd7b62fdfa6a1fbd882d1565d557577f2cf32')
0 files changed, 0 insertions, 0 deletions