diff options
Fix mousereport
This patch replaces the previous one I sent.
The following changes are made in this patch:
- Fix tracking of pressed buttons. Previously, pressing two buttons and
then releasing one would make st think no buttons are pressed, which
in particular broke MODE_MOUSEMOTION.
- Always send the lowest-numbered pressed button on motion events; when
no button is pressed for a motion event in MODE_MOUSEMANY, then send
a release. This matches the behaviour of xterm. (Previously, st sent
the most recently pressed button in the motion report.)
- Remove UB (?) access to potentially inactive struct member
e->xbutton.button of XEvent union.
- Fix (unlikely) possibility of overflow for large button numbers.
The one discrepancy I found between st and xterm is that xterm sometimes
encodes buttons with large numbers (>5) strangely. E.g., xterm reports
presses of buttons 8 and 9 as releases, whereas st properly (?) encodes
them as presses.
Diffstat (limited to '%25252525252525252525253fid%25252525252525252525253dfffee341e56206a036d0b69de7292e72ed887638%252525252525252525253fid%252525252525252525253dfffee341e56206a036d0b69de7292e72ed887638%2525252525252525253fid%2525252525252525253dd4eee428f9c7b7f0aeb34042677bce4f98431fa6%25252525252525253fid%25252525252525253d990bdee7b3ae54b8b9fbe7b565f9072552c3771d%252525252525253fid%252525252525253d990bdee7b3ae54b8b9fbe7b565f9072552c3771d%2525252525253fid%2525252525253d670ddec83f39b5544555952a7c737c878569e1a2%25252525253fid%25252525253db1d97fec47b0d6633addb848131388ec40154ebc%252525253fid%252525253db1d97fec47b0d6633addb848131388ec40154ebc%2525253fid%2525253db1d97fec47b0d6633addb848131388ec40154ebc%25253fid%25253db1d97fec47b0d6633addb848131388ec40154ebc%253fid%253db1d97fec47b0d6633addb848131388ec40154ebc%3fid%3dea7cd7b62fdfa6a1fbd882d1565d557577f2cf32?id=ea7cd7b62fdfa6a1fbd882d1565d557577f2cf32')
0 files changed, 0 insertions, 0 deletions