diff options
author | NRK <nrk@disroot.org> | 2022-10-31 00:10:45 +0600 |
---|---|---|
committer | Hiltjo Posthuma <hiltjo@codemadness.org> | 2022-10-31 11:40:35 +0100 |
commit | 689d9bfcf6859e5ce85c296ff0f23b5c08b1fedc (patch) | |
tree | a1ca8529c6b4ea7f1be7fc39a86c450830d1f128 /config.def.h%252525252525252525252525253fid%252525252525252525252525253d120e8401074254d39be916ad83bafda9ef25e6a9%25252525252525253fid2%25252525252525253d5773a77780fee2424ad561c1c83136f45e2b1a67%2525253fid%2525253d5773a77780fee2424ad561c1c83136f45e2b1a67%25253fid%25253dba1a347dcaba055f824161007dfee60db3ea785b%253fid%253dbcbc1ef5c4cf4875a4d66e7dc0919da88a6096a5%3fid%3d689d9bfcf6859e5ce85c296ff0f23b5c08b1fedc?id=689d9bfcf6859e5ce85c296ff0f23b5c08b1fedc | |
parent | e42c03663442f5fb2f66dd59cc5bfdc61c53192c (diff) |
fix leak when getline fails
according to the getline(3) documentation, the calling code needs to
free the buffer even if getline fails.
dmenu currently doesn't do that which results in a small leak in case of
failure (e.g when piped /dev/null)
$ ./dmenu < /dev/null
==8201==ERROR: LeakSanitizer: detected memory leaks
Direct leak of 120 byte(s) in 1 object(s) allocated from:
#0 0x7f6bf5785ef7 in malloc
#1 0x7f6bf538ec84 in __getdelim
#2 0x405d0c in readstdin dmenu.c:557
moving `line = NULL` inside the loop body wasn't strictly necessary, but
IMO it makes it more apparent that `line` is getting cleared to NULL
after each successful iteration.
Diffstat (limited to 'config.def.h%252525252525252525252525253fid%252525252525252525252525253d120e8401074254d39be916ad83bafda9ef25e6a9%25252525252525253fid2%25252525252525253d5773a77780fee2424ad561c1c83136f45e2b1a67%2525253fid%2525253d5773a77780fee2424ad561c1c83136f45e2b1a67%25253fid%25253dba1a347dcaba055f824161007dfee60db3ea785b%253fid%253dbcbc1ef5c4cf4875a4d66e7dc0919da88a6096a5%3fid%3d689d9bfcf6859e5ce85c296ff0f23b5c08b1fedc?id=689d9bfcf6859e5ce85c296ff0f23b5c08b1fedc')
0 files changed, 0 insertions, 0 deletions