summaryrefslogtreecommitdiff
path: root/%25252525252525252525253fid%25252525252525252525253d1d2b462acf1210b8f86966b8d...
diff options
context:
space:
mode:
authorNRK <nrk@disroot.org>2022-10-31 00:10:45 +0600
committerHiltjo Posthuma <hiltjo@codemadness.org>2022-10-31 11:40:35 +0100
commit689d9bfcf6859e5ce85c296ff0f23b5c08b1fedc (patch)
treea1ca8529c6b4ea7f1be7fc39a86c450830d1f128 /%25252525252525252525253fid%25252525252525252525253d1d2b462acf1210b8f86966b8dd9bb6e36e369ee1%252525252525252525253fid%252525252525252525253d7ec32fe4944d4f7137cf2a23366324ffe0f10a70%2525252525252525253fid%2525252525252525253dfce06f437dcec646ee0a2728fe695f3084cc6ccb%25252525252525253fid%25252525252525253d1e8c5b68f4881bd4ae257c780fd41f129c79f419%252525253fid%252525253ddfbbf7f6e1b22ccf9e5a45d77ee10995577fb4fc%2525253fid%2525253dba1a347dcaba055f824161007dfee60db3ea785b%25253fid%25253dbcbc1ef5c4cf4875a4d66e7dc0919da88a6096a5%253fid%253d689d9bfcf6859e5ce85c296ff0f23b5c08b1fedc%3fid%3d689d9bfcf6859e5ce85c296ff0f23b5c08b1fedc?id=689d9bfcf6859e5ce85c296ff0f23b5c08b1fedc
parente42c03663442f5fb2f66dd59cc5bfdc61c53192c (diff)
fix leak when getline fails
according to the getline(3) documentation, the calling code needs to free the buffer even if getline fails. dmenu currently doesn't do that which results in a small leak in case of failure (e.g when piped /dev/null) $ ./dmenu < /dev/null ==8201==ERROR: LeakSanitizer: detected memory leaks Direct leak of 120 byte(s) in 1 object(s) allocated from: #0 0x7f6bf5785ef7 in malloc #1 0x7f6bf538ec84 in __getdelim #2 0x405d0c in readstdin dmenu.c:557 moving `line = NULL` inside the loop body wasn't strictly necessary, but IMO it makes it more apparent that `line` is getting cleared to NULL after each successful iteration.
Diffstat (limited to '%25252525252525252525253fid%25252525252525252525253d1d2b462acf1210b8f86966b8dd9bb6e36e369ee1%252525252525252525253fid%252525252525252525253d7ec32fe4944d4f7137cf2a23366324ffe0f10a70%2525252525252525253fid%2525252525252525253dfce06f437dcec646ee0a2728fe695f3084cc6ccb%25252525252525253fid%25252525252525253d1e8c5b68f4881bd4ae257c780fd41f129c79f419%252525253fid%252525253ddfbbf7f6e1b22ccf9e5a45d77ee10995577fb4fc%2525253fid%2525253dba1a347dcaba055f824161007dfee60db3ea785b%25253fid%25253dbcbc1ef5c4cf4875a4d66e7dc0919da88a6096a5%253fid%253d689d9bfcf6859e5ce85c296ff0f23b5c08b1fedc%3fid%3d689d9bfcf6859e5ce85c296ff0f23b5c08b1fedc?id=689d9bfcf6859e5ce85c296ff0f23b5c08b1fedc')
0 files changed, 0 insertions, 0 deletions